Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new rule] validate subgraph according federation 2 #2049

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dimaMachina
Copy link
Owner

Part of #1824

I am new in the Federation spec and feel like validation should be split into 2 rules

  • validation of supergraph
  • validation of subgraph (current PR)

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: fc49d5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +46 to +50
"peerDependenciesMeta": {
"@apollo/federation-internals": {
"optional": true
}
},
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think people should explicitly install this dependency if they want to validate federation schema, there is no need to add to dependencies

} from '@apollo/federation-internals';
import { GraphQLESLintRule } from '../types.js';

const RULE_ID = 'federation-subgraph';
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any suggestions to rule name?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apollo-federation-subgraph would be more precise?

"@apollo/federation-internals": {
"optional": true
}
},
"dependencies": {
"@graphql-tools/code-file-loader": "^8.0.0",
"@graphql-tools/graphql-tag-pluck": "^8.0.0",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add @graphql-tools/graphql-tag-pluck also to peerDependencies in v4, since it's a big dependency that installs a lot of things (not everybody lint code files)

@cgriego
Copy link

cgriego commented Feb 21, 2024

What's needed to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants